Change in osmo-hlr[master]: add mDNS lookup method to libosmo-mslookup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Dec 3 14:14:58 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16256 )

Change subject: add mDNS lookup method to libosmo-mslookup
......................................................................


Patch Set 8:

(2 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns.c 
File src/mslookup/mdns.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns.c@117 
PS7, Line 117: 		case OSMO_MDNS_RFC_RECORD_TYPE_A:
> Typically no indent of case in switch, but not critical
Done


https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns_msg.c 
File src/mslookup/mdns_msg.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns_msg.c@67 
PS7, Line 67: 	ret = talloc(ctx, struct osmo_mdns_msg_request);
> We rarely ose talloc without _zero as a safeguard. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I03a0ffa1d4dc1b24ac78a5ad0975bca90a49c728
Gerrit-Change-Number: 16256
Gerrit-PatchSet: 8
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 03 Dec 2019 14:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191203/fc36929e/attachment.htm>


More information about the gerrit-log mailing list