Change in simtrace2[master]: simtrace2_api: Remove dead code

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Dec 2 18:43:45 UTC 2019


laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16410 )

Change subject: simtrace2_api: Remove dead code
......................................................................

simtrace2_api: Remove dead code

Change-Id: Iab393a6cf9ae1218e1554d9c0bfb7aab2cc3c35e
---
M host/lib/simtrace2_api.c
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/host/lib/simtrace2_api.c b/host/lib/simtrace2_api.c
index 7a0289d..b2b2829 100644
--- a/host/lib/simtrace2_api.c
+++ b/host/lib/simtrace2_api.c
@@ -38,11 +38,8 @@
 
 #include <libusb.h>
 
-//#include <osmocom/simtrace2/libusb_util.h>
 #include <osmocom/simtrace2/simtrace_prot.h>
 #include <osmocom/simtrace2/simtrace2_api.h>
-//#include "apdu_dispatch.h"
-//#include "simtrace2-discovery.h"
 
 #include <osmocom/core/utils.h>
 #include <osmocom/core/socket.h>
@@ -60,14 +57,6 @@
 	return msgb_alloc_headroom(1024+32, 32, "SIMtrace");
 }
 
-#if 0
-static void apdu_out_cb(uint8_t *buf, unsigned int len, void *user_data)
-{
-	printf("APDU: %s\n", osmo_hexdump(buf, len));
-	gsmtap_send_sim(buf, len);
-}
-#endif
-
 /*! \brief Transmit a given command to the SIMtrace2 device */
 int osmo_st2_transp_tx_msg(struct osmo_st2_transport *transp, struct msgb *msg)
 {

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Iab393a6cf9ae1218e1554d9c0bfb7aab2cc3c35e
Gerrit-Change-Number: 16410
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191202/69511a34/attachment.htm>


More information about the gerrit-log mailing list