Change in simtrace2[master]: simtrace2-remsim: Use simplest ATR

[laforge]

Hello tsaitgaist,

I'd like you to do a code review. Please visit

    https://gerrit.osmocom.org/c/simtrace2/+/16420

to review the following change.


Change subject: simtrace2-remsim: Use simplest ATR
......................................................................

simtrace2-remsim: Use simplest ATR

this ATR does not encode any data and uses all defaults.
the lower default speed is also better handled by the hardware.
handling faster speeds is upcoming.

Change-Id: I5a4f2f94bea1a15aedbef5a6f2f49344387dc11d
---
M host/src/simtrace2-remsim.c
1 file changed, 1 insertion(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/20/16420/1

diff --git a/host/src/simtrace2-remsim.c b/host/src/simtrace2-remsim.c
index 03d11df..d51f081 100644
--- a/host/src/simtrace2-remsim.c
+++ b/host/src/simtrace2-remsim.c
@@ -432,9 +432,7 @@
 
 		if (!skip_atr) {
 			/* set the ATR */
-			uint8_t real_atr[] = {  0x3B, 0x9F, 0x96, 0x80, 0x1F, 0xC7, 0x80, 0x31,
-						0xA0, 0x73, 0xBE, 0x21, 0x13, 0x67, 0x43, 0x20,
-						0x07, 0x18, 0x00, 0x00, 0x01, 0xA5 };
+			uint8_t real_atr[] = {  0x3B, 0x00 }; // the simplest ATR
 			atr_update_csum(real_atr, sizeof(real_atr));
 			osmo_st2_cardem_request_set_atr(ci, real_atr, sizeof(real_atr));
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16420
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I5a4f2f94bea1a15aedbef5a6f2f49344387dc11d
Gerrit-Change-Number: 16420
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: tsaitgaist <kredon at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191202/f9d98935/attachment.htm>