Change in libosmo-abis[master]: input/ipaccess.c: propagate errors from ipa_parse_unitid()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Dec 1 19:45:10 UTC 2019


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16391 )


Change subject: input/ipaccess.c: propagate errors from ipa_parse_unitid()
......................................................................

input/ipaccess.c: propagate errors from ipa_parse_unitid()

Change-Id: Ic190daae31936959de8efb5a6de8744c016d5643
---
M src/input/ipaccess.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/91/16391/1

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 0f8e2d5..65851ef 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -143,7 +143,11 @@
 		}
 		unitid = (char *) TLVP_VAL(&tlvp, IPAC_IDTAG_UNIT);
 		unitid[len - 1] = '\0';
-		ipa_parse_unitid(unitid, &unit_data);
+		ret = ipa_parse_unitid(unitid, &unit_data);
+		if (ret) {
+			LOGP(DLINP, LOGL_ERROR, "Failed to parse unit ID '%s'\n", unitid);
+			goto err;
+		}
 
 		if (!line->ops->sign_link_up) {
 			LOGP(DLINP, LOGL_ERROR,

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/16391
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ic190daae31936959de8efb5a6de8744c016d5643
Gerrit-Change-Number: 16391
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191201/9964a5cd/attachment.htm>


More information about the gerrit-log mailing list