Change in osmo-mgw[master]: mgcp_client: Check for osmo_fsm_register() error return value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Dec 1 13:45:52 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/16361 )

Change subject: mgcp_client: Check for osmo_fsm_register() error return value
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/16361/1/src/libosmo-mgcp-client/mgcp_client_fsm.c 
File src/libosmo-mgcp-client/mgcp_client_fsm.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/16361/1/src/libosmo-mgcp-client/mgcp_client_fsm.c@623 
PS1, Line 623: osmo_fsm_register
Can we just move this to a function with __attribute__((constructor)), and use OSMO_ASSERT() as we do in the other projects?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/16361
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ie5e7fa419117349d098b0158ed840341094f3c16
Gerrit-Change-Number: 16361
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 01 Dec 2019 13:45:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20191201/d51972ef/attachment.htm>


More information about the gerrit-log mailing list