This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15307 ) Change subject: Introduce log helper LOGGGSN ...................................................................... Patch Set 2: (3 comments) So you're not only adding LOGGGSN() macro, but also a new DGTP logging category. Please either state this in the commit message, or move to a separate change. https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h@410 PS2, Line 410: INET_ADDRSTRLEN What about '\0'? As far as I can see, other code parts are using INET_ADDRSTRLEN + 1, while in libosmocore we just use INET_ADDRSTRLEN... https://gerrit.osmocom.org/#/c/15307/2/include/osmocom/sgsn/gprs_sgsn.h@411 PS2, Line 411: &(ggc)->remote_addr So this address is always IPv4, right? https://gerrit.osmocom.org/#/c/15307/2/src/gprs/sgsn_main.c File src/gprs/sgsn_main.c: https://gerrit.osmocom.org/#/c/15307/2/src/gprs/sgsn_main.c@348 PS2, Line 348: } Let's make it git-friendly and add a comma. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15307 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I30f46f44af1d0eee324b1a995c1dad2e1315af7c Gerrit-Change-Number: 15307 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 29 Aug 2019 23:36:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190829/32218086/attachment.htm>