This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/15256 )
Change subject: ggsn_vty.c: Improve output of VTY show pdp-context
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/15256/2/ggsn/ggsn_vty.c
File ggsn/ggsn_vty.c:
https://gerrit.osmocom.org/#/c/15256/2/ggsn/ggsn_vty.c@762
PS2, Line 762: if (!pdp->secondary) {
> (consider writing the non-inverted condition first)
I'd prefer keeping it this way since it's the "main" branch, since pdp contexts are mostly primary.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/15256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: If9682fe343e9a1e78175a12538fb80d4bda54802
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: osmith <osmith at sysmocom.de>
Gerrit-Comment-Date: Wed, 28 Aug 2019 09:07:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190828/d15854b2/attachment.htm>