This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15265 ) Change subject: fix: vty crash by logging to killed telnet session ...................................................................... Patch Set 2: I'm sorry but I don't agree here. I don't think adding lots of checks against null pointers all around the code to make sure we don't crash on situation that shouldn't happen is good practice. It makes code harder to follow and make people infer bad assumptions, and masks bugs. I'm not making a huge thing of it, that's why I think these checks shouldn't be there. If someone else agrees to merge this one go on, but I don't like it. I expect the correct fix for this issue (that is, as you said, removing the conn from the target list before printing in telnet_close_client()). -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idca3f54dc986abf6784790c12e69e02bdf77cb41 Gerrit-Change-Number: 15265 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 27 Aug 2019 16:24:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190827/45658ee8/attachment.htm>