This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15290 Change subject: Transceiver: Fix idle ul burst indications being dropped ...................................................................... Transceiver: Fix idle ul burst indications being dropped pullRadioVector() should return true on idle frames because those indications may be handled by upper layers (TRXDv1). Clarify return code in function documentation. Change-Id: If592ed1c04cf7e995f656b313f60edd4d40d1bfd --- M Transceiver52M/Transceiver.cpp 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/90/15290/1 diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp index 0a78c11..9a1c446 100644 --- a/Transceiver52M/Transceiver.cpp +++ b/Transceiver52M/Transceiver.cpp @@ -587,6 +587,7 @@ /* * Pull bursts from the FIFO and handle according to the slot * and burst correlation type. Equalzation is currently disabled. + * returns true on success (bi filled), false on error (bi content undefined). */ bool Transceiver::pullRadioVector(size_t chan, struct trx_ul_burst_ind *bi) { @@ -708,7 +709,7 @@ ret_idle: bi->idle = true; delete radio_burst; - return false; + return true; } void Transceiver::reset() -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15290 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If592ed1c04cf7e995f656b313f60edd4d40d1bfd Gerrit-Change-Number: 15290 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190826/56eaaeb5/attachment.htm>