This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15289 ) Change subject: Transceiver: exit process when BTS drops connection ...................................................................... Patch Set 2: Code-Review-1 (1 comment) > No, true means success and false means failure everywhere. Ok, nevermind. I was reading too quickly. I know you don't like C++ and its specific features, but I still think it makes more sense to use exceptions here. You can just catch them in *LoopAdapter() calls and terminate the process instead of spamming the code with dozens of `return true / false`. https://gerrit.osmocom.org/#/c/15289/2/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/#/c/15289/2/Transceiver52M/Transceiver.cpp@1041 PS2, Line 1041: if (bi.idle) : return true; Here you're changing the logic, so the IDLE indications would never be passed to trxd_send_burst_ind_*(). Not sure if this is intended. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15289 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2ccbe3c17b39fb792ea7810f840235c348054d66 Gerrit-Change-Number: 15289 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 26 Aug 2019 13:15:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190826/ea358c1d/attachment.htm>