This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15278 ) Change subject: osmobts_sock.cpp: pcu_sock_cb(): use libosmocore's socket API ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/15278/2/src/osmobts_sock.cpp File src/osmobts_sock.cpp: https://gerrit.osmocom.org/#/c/15278/2/src/osmobts_sock.cpp@265 PS2, Line 265: state->conn_bfd.cb = pcu_sock_cb; > I think these 2 lines should be set before calling osmo_sock_unix_init_ofd()? Or is it fine this way […] I think it's fine to do it here. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15278 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7f5c7f5744ab14f36f46cf7941e91352eca8d2b9 Gerrit-Change-Number: 15278 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 23 Aug 2019 16:32:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190823/c59c82cb/attachment.htm>