This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 ) Change subject: gprs_gmm: Avoid spaces in fsm events and enum strings ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm.c@110 PS1, Line 110: { PMM_DETACHED, "PMM_DETACH" }, > maybe while at it fix to "PMM_DETACHED" (or what Vadim said) I'll use OSMO_VALUE_STRING, thanks. https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm_attach.c File src/gprs/gprs_gmm_attach.c: https://gerrit.osmocom.org/#/c/15212/1/src/gprs/gprs_gmm_attach.c@328 PS1, Line 328: { E_VLR_ANSWERED, "VLR_ANSWERED"}, > (this could also use OSMO_VALUE_STRING(); IMHO it's an advantage to print exactly the event names as […] ACK -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1 Gerrit-Change-Number: 15212 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 15 Aug 2019 09:30:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190815/bbfbce6d/attachment.htm>