This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 ) Change subject: Introduce and use log macros when no mm ctx available ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/15211/1/include/osmocom/sgsn/gprs_sgsn.h File include/osmocom/sgsn/gprs_sgsn.h: https://gerrit.osmocom.org/#/c/15211/1/include/osmocom/sgsn/gprs_sgsn.h@264 PS1, Line 264: #define LOGIUP(level, ue, fmt, args...) \ > (cosmetic) […] Yes I also noticed that. Fine, I'll try to change the order for new macros. https://gerrit.osmocom.org/#/c/15211/1/include/osmocom/sgsn/gprs_sgsn.h@284 PS1, Line 284: > (in osmo-msc and -bsc I named the logging macros more like LOG_HO and LOG_MSC_A, for readability. […] That depends on the project. I still to currently used one here, and it takes less space too. https://gerrit.osmocom.org/#/c/15211/1/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/15211/1/src/gprs/gprs_gmm.c@185 PS1, Line 185: LOGIUP(LOGL_NOTICE, ctx, "Cannot find mm ctx for IU event %d\n", type); \ > (we have a value string for those events, see ranap_iu_event_type_str() from iu_client. […] Probably deserves a different patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Iba22060d8646bc8ec6227684ccb91d98cb4c7be2 Gerrit-Change-Number: 15211 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2019 09:29:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190815/c8952e3e/attachment.htm>