This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15218 ) Change subject: osmo_tdef_get(): allow passing -1 as default timeout ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/15218/2/src/tdef.c File src/tdef.c: https://gerrit.osmocom.org/#/c/15218/2/src/tdef.c@186 PS2, Line 186: osmo_tdef_get Alternatively, you could add another function without that optional parameter, so it would simply crash the process if (t == NULL), while this function would always return the val_if_not_present. Just an idea. The current approach also looks good. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie61c3c85069916336e6dbd91a2c16f7634816417 Gerrit-Change-Number: 15218 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 15 Aug 2019 07:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190815/bbd9946c/attachment.htm>