This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
keith gerrit-no-reply at lists.osmocom.orgkeith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 ) Change subject: avoid bogus error logs when no cmd_timer is set ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/15142/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/15142/1/src/mncc.c@74 PS1, Line 74: if (!osmo_timer_pending(&leg->cmd_timeout)) As far as I can make out, we only start timers immediately before sending an MNCC command to which we expect the response that will call stop_cmd_timer. The timeout is hard coded to five seconds. If there are incoming unexpected MNCC commands that are triggering stop_cmd_timer after the timeout, then something is wrong, no? -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I70f85a71df55ab8618ed78864cefb6fe5b26f581 Gerrit-Change-Number: 15142 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-CC: keith <keith at rhizomatica.org> Gerrit-Comment-Date: Mon, 12 Aug 2019 16:19:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190812/778c209a/attachment.htm>