This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13866 ) Change subject: sgsn: Actual first Iu test case ...................................................................... Patch Set 4: (5 comments) https://gerrit.osmocom.org/#/c/13866/4/sgsn/SGSN_Tests.ttcn File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/#/c/13866/4/sgsn/SGSN_Tests.ttcn@466 PS4, Line 466: private function f_send_l3_gmm_llc(template (value) PDU_L3_MS_SGSN l3_mo, integer gb_index := 0) runs on BSSGP_ConnHdlr { This looks unrelated? https://gerrit.osmocom.org/#/c/13866/4/sgsn/SGSN_Tests.ttcn@492 PS4, Line 492: rNC_ID := 2342 /* FIXME */ Can you extend the FIXME here and a few lines above? https://gerrit.osmocom.org/#/c/13866/4/sgsn/SGSN_Tests.ttcn@508 PS4, Line 508: if (gb_index >= NUM_GB) { AFAIU, you use gb_index >= NUM_GB to know if conn is Iu or Gb? Can you add a function is_iu(gb_index) for that? so it becomes easy to understand. Or perhaps have an extra param signalling which protocol we use (simlar to what we already have for SCCPLITE vs AoIP in other tests). https://gerrit.osmocom.org/#/c/13866/4/sgsn/SGSN_Tests.ttcn@628 PS4, Line 628: //BSSAP.receive(tr_RANAP_CommonId(imsi_hex2oct(g_pars.imsi))); Why is this commented? https://gerrit.osmocom.org/#/c/13866/4/sgsn/SGSN_Tests_Iu.ttcn File sgsn/SGSN_Tests_Iu.ttcn: https://gerrit.osmocom.org/#/c/13866/4/sgsn/SGSN_Tests_Iu.ttcn@534 PS4, Line 534: This repeat seems unrelated. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/13866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66069e31c30d33934ad57cc2b8794f56ffd5c7d6 Gerrit-Change-Number: 13866 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 12 Aug 2019 13:38:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190812/24c14ad2/attachment.htm>