This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/15130 Change subject: rename codecs_cmp() to codecs_same() ...................................................................... rename codecs_cmp() to codecs_same() The name 'cmp' implies a return value of -1, 0, 1 to indicate smaller, match or larger. Since this function returns bool, it should not be named with 'cmp'. Change-Id: I2d41b1a32300e295551e85d3f9ab82dd2b0e86b8 --- M src/libosmo-mgcp/mgcp_codec.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/30/15130/1 diff --git a/src/libosmo-mgcp/mgcp_codec.c b/src/libosmo-mgcp/mgcp_codec.c index 8be4c3c..e9e2c62 100644 --- a/src/libosmo-mgcp/mgcp_codec.c +++ b/src/libosmo-mgcp/mgcp_codec.c @@ -352,7 +352,7 @@ /* Compare two codecs, all parameters must match up, except for the payload type * number. */ -static bool codecs_cmp(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b) +static bool codecs_same(struct mgcp_rtp_codec *codec_a, struct mgcp_rtp_codec *codec_b) { if (codec_a->rate != codec_b->rate) return false; @@ -406,7 +406,7 @@ codecs_assigned = rtp_dst->codecs_assigned; OSMO_ASSERT(codecs_assigned <= MGCP_MAX_CODECS); for (i = 0; i < codecs_assigned; i++) { - if (codecs_cmp(codec_src, &rtp_dst->codecs[i])) { + if (codecs_same(codec_src, &rtp_dst->codecs[i])) { codec_dst = &rtp_dst->codecs[i]; break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/15130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I2d41b1a32300e295551e85d3f9ab82dd2b0e86b8 Gerrit-Change-Number: 15130 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190809/06ca46c6/attachment.htm>