Change in ...osmo-sip-connector[master]: Add further logging.

[keith]

keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997 )

Change subject: Add further logging.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c 
File src/mncc.c:

https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@191 
PS1, Line 191: 	struct in_addr net = { .s_addr = other->ip };
> Are you sure this is correct? or you need to use mncc. […]
Yes, mncc.ip is in host byte order, if that's the correct terminology. certainly, using mncc.ip here result in the IP in the log message being printed "backwards"


https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@192 
PS1, Line 192: 	LOGP(DMNCC, LOGL_DEBUG, "SEND rtp_connect: IP=(%s) PORT=(%u)\n", inet_ntoa(net), mncc.port);
> Better use inet_ntop().
There are other places in the code that use inet_ntoa()
Would it be better to accept this patch and then submit another changing them all to inet_ntop() ?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b
Gerrit-Change-Number: 14997
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Aug 2019 19:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190805/bf360f69/attachment.htm>