Change in osmo-gsm-tester[master]: virtual: The completion ratio is success / success+failure

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Mon Apr 29 21:12:50 UTC 2019


Holger Freyther has submitted this change and it was merged. ( https://gerrit.osmocom.org/13803 )

Change subject: virtual: The completion ratio is success / success+failure
......................................................................

virtual: The completion ratio is success / success+failure

Fix the stats code to calculate the real completion ratio.

Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
---
M suites/nitb_netreg_mass/register_default_mass.py
M suites/nitb_netreg_mass/suite.conf
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/suites/nitb_netreg_mass/register_default_mass.py b/suites/nitb_netreg_mass/register_default_mass.py
index 76c53f1..306eb81 100644
--- a/suites/nitb_netreg_mass/register_default_mass.py
+++ b/suites/nitb_netreg_mass/register_default_mass.py
@@ -38,7 +38,7 @@
 stats = ms_driver.get_stats()
 if len(modems) > 0 and stats.num_completed < 1:
     raise Exception("No run completed.")
-completion_ratio = stats.num_attempted / stats.num_completed
+completion_ratio = stats.num_completed / stats.num_attempted
 
 # Verify that 99% of LUs completed.
 if completion_ratio < 0.99:
diff --git a/suites/nitb_netreg_mass/suite.conf b/suites/nitb_netreg_mass/suite.conf
index 44de0b6..bb1585b 100644
--- a/suites/nitb_netreg_mass/suite.conf
+++ b/suites/nitb_netreg_mass/suite.conf
@@ -8,4 +8,4 @@
     type: osmo-mobile
 
 defaults:
-  timeout: 40s
+  timeout: 50s

-- 
To view, visit https://gerrit.osmocom.org/13803
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b8f32dfbe8faa4c255a8d2d9806303fc8e5933b
Gerrit-Change-Number: 13803
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190429/10cfdfe2/attachment.htm>


More information about the gerrit-log mailing list