Change in osmo-msc[master]: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Apr 26 11:06:01 UTC 2019


Max has posted comments on this change. ( https://gerrit.osmocom.org/13655 )

Change subject: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/#/c/13655/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/13655/1//COMMIT_MSG@25
PS1, Line 25: Preventing this would require adding an additional check.
Is there a ticket for that? If so please reference it in here otherwise create it and than reference :)


https://gerrit.osmocom.org/#/c/13655/1/src/libmsc/gsm_04_11.c
File src/libmsc/gsm_04_11.c:

https://gerrit.osmocom.org/#/c/13655/1/src/libmsc/gsm_04_11.c@574
PS1, Line 574: 					  "TP-User-Data-Length %u (septets) "
What's the point of splitting the strings this way? We're well within the length limit.



-- 
To view, visit https://gerrit.osmocom.org/13655
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4b08db7665e854a045129e7695e2bdf296df1688
Gerrit-Change-Number: 13655
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Max <suraev at alumni.ntnu.no>
Gerrit-Comment-Date: Fri, 26 Apr 2019 11:06:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190426/c98a4027/attachment.htm>


More information about the gerrit-log mailing list