This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13744 ) Change subject: gprs_gmm: send Service Reject when no PDP ctxs are available. ...................................................................... Patch Set 5: (2 comments) Only minor stuff, thanks! https://gerrit.osmocom.org/#/c/13744/5/src/gprs/gprs_gmm.c File src/gprs/gprs_gmm.c: https://gerrit.osmocom.org/#/c/13744/5/src/gprs/gprs_gmm.c@1620 PS5, Line 1620: * network. */ Please also leave the old comment together with the new additions, it's handy to understand what the function does quickly before looking at it: "Returns false if any active PDP context in pdp_status is not present in the pdp_list for given MS". https://gerrit.osmocom.org/#/c/13744/5/src/gprs/gprs_gmm.c@1628 PS5, Line 1628: for (pdp_nsapi = 0, i = 0; i < pdp_status_len; i = (++pdp_nsapi) / 8) { Probably much clear to have simple pdp_nsapi++ in the foor loop clause, then in body have: i = pdp_nsapi / 8; if (!(pdp_status[i] & (1 << (pdp_nsapi - 8 * i)))) -- To view, visit https://gerrit.osmocom.org/13744 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If610cbef17c25ec44e65d4f1b2340d102c560437 Gerrit-Change-Number: 13744 Gerrit-PatchSet: 5 Gerrit-Owner: Mykola Shchetinin <mykola at pentonet.com> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Mykola Shchetinin <mykola at pentonet.com> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 24 Apr 2019 11:58:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190424/297f2292/attachment.htm>