This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vasil Velichkov gerrit-no-reply at lists.osmocom.orgHello Piotr Krysik, Vadim Yanitskiy, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/13671 to review the following change. Change subject: Improve the TCH/H decoder logs ...................................................................... Improve the TCH/H decoder logs - Change "6,90 kbit/s" to "5.9 kbit/s" A typo reported in github ptrkrysik/gr-gsm#456 - Comment out the "Error! frame_nr:" message as it turns out to confuse users more then it actually helps debugging. - When voice-boundary detection is enabled write the name of decoded control channel messages Change-Id: I697ef944f30c4cabb62c888317dd3a7f8dcd5611 --- M lib/decoding/tch_h_decoder_impl.cc 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/71/13671/1 diff --git a/lib/decoding/tch_h_decoder_impl.cc b/lib/decoding/tch_h_decoder_impl.cc index 11da907..96d6714 100644 --- a/lib/decoding/tch_h_decoder_impl.cc +++ b/lib/decoding/tch_h_decoder_impl.cc @@ -178,7 +178,7 @@ std::cout<<"5,15 kbit/s codec rate: is part of the subset"<<std::endl; break; case 2: - std::cout<<"6,90 kbit/s codec rate: is part of the subset"<<std::endl; + std::cout<<"5,90 kbit/s codec rate: is part of the subset"<<std::endl; break; case 3: std::cout<<"6,70 kbit/s codec rate: is part of the subset"<<std::endl; @@ -266,10 +266,10 @@ if (frameLength < 12) { - if (!d_boundary_check || d_boundary_decode) { - std::cerr<<"Error! frame_nr:"<<frame_nr<<" mod26:"<<frame_nr%26 - <<" fn_is_odd:"<<fn_is_odd<<" length:"<<frameLength<<std::endl; - } + //if (!d_boundary_check || d_boundary_decode) { + // std::cerr<<"Error! frame_nr:"<<frame_nr<<" mod26:"<<frame_nr%26 + // <<" fn_is_odd:"<<fn_is_odd<<" length:"<<frameLength<<std::endl; + //} return; } else if (frameLength == GSM_MACBLOCK_LEN) //FACCH/H @@ -301,6 +301,7 @@ (frameBuffer[6] == 2) && //length ((frameBuffer[8] & 0x7f) == 0x08)) { + std::cout << "(CC) Alerting with In-band information" << std::endl; //.000 1000 = Progress description: In-band information or appropriate pattern now available (8) d_boundary_decode = true; } @@ -311,6 +312,7 @@ if ((frameBuffer[5] == 2) && //length (frameBuffer[7] & 0x7f) == 0x08) { + std::cout << "(CC) Progress with In-band information" << std::endl; //.000 1000 = Progress description: In-band information or appropriate pattern now available (8) d_boundary_decode = true; } @@ -318,16 +320,19 @@ // Connect specified in GSM 04.08, 9.3.5 else if ((frameBuffer[4] & 0x3f) == 0x07) { + std::cout << "(CC) Connect" << std::endl; d_boundary_decode = true; } // Connect Acknowledge specified in GSM 04.08, 9.3.6 else if ((frameBuffer[4] & 0x3f) == 0x0f) { + std::cout << "(CC) Connect Acknowledge" << std::endl; d_boundary_decode = true; } // Release specified in GSM 04.08, 9.3.18 else if ((frameBuffer[4] & 0x3f) == 0x2d) { + std::cout << "(CC) Release" << std::endl; d_boundary_decode = false; } } -- To view, visit https://gerrit.osmocom.org/13671 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I697ef944f30c4cabb62c888317dd3a7f8dcd5611 Gerrit-Change-Number: 13671 Gerrit-PatchSet: 1 Gerrit-Owner: Vasil Velichkov <vvvelichkov at gmail.com> Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/48308c35/attachment.htm>