Change in osmo-ccid-firmware[master]: main.c: Call ncn8025_init also for SIM7

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Apr 16 16:22:03 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13666 )

Change subject: main.c: Call ncn8025_init also for SIM7
......................................................................

main.c: Call ncn8025_init also for SIM7

The ncn8025 has no impact on the UART, so no matter if we use
SERCOM7 as debug uart or as SIM UART, we can always initialize
the NCN8025 and thereby allow control of (e.g.) the LED.

Change-Id: I70ae1e050d5540627bc77626dbf1b6040e95dae4
---
M sysmoOCTSIM/main.c
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/sysmoOCTSIM/main.c b/sysmoOCTSIM/main.c
index dc67406..9dee504 100644
--- a/sysmoOCTSIM/main.c
+++ b/sysmoOCTSIM/main.c
@@ -39,8 +39,7 @@
 	for (i = 0; i < 4; i++)
 		i2c_init(&i2c[i]);
 
-	/* only 7 slots, as last slot is debug uart! */
-	for (i = 0; i < 7; i++)
+	for (i = 0; i < 8; i++)
 		ncn8025_init(i);
 
 	cache_init();

-- 
To view, visit https://gerrit.osmocom.org/13666
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I70ae1e050d5540627bc77626dbf1b6040e95dae4
Gerrit-Change-Number: 13666
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-CC: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190416/d83572b0/attachment.htm>


More information about the gerrit-log mailing list