Change in osmo-msc[master]: Allow MME name preformatted as FQDN in SGsAP

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Omar Ramadan gerrit-no-reply at lists.osmocom.org
Fri Apr 12 22:24:00 UTC 2019


Omar Ramadan has uploaded this change for review. ( https://gerrit.osmocom.org/13627


Change subject: Allow MME name preformatted as FQDN in SGsAP
......................................................................

Allow MME name preformatted as FQDN in SGsAP

Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
---
M src/libmsc/sgs_iface.c
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/27/13627/1

diff --git a/src/libmsc/sgs_iface.c b/src/libmsc/sgs_iface.c
index f64b191..9ad8021 100644
--- a/src/libmsc/sgs_iface.c
+++ b/src/libmsc/sgs_iface.c
@@ -167,6 +167,12 @@
 	if (!mme_name_enc)
 		return -EINVAL;
 
+	/* some implementations use FDQN format violating TS 29.118 9.3.14 */
+	if (!osmo_parse_mme_domain(&gummei, (const char *) mme_name_enc)) {
+		memcpy(mme_name, mme_name_enc, TLVP_LEN(tp, SGSAP_IE_MME_NAME));
+		return 0;
+	}
+
 	/* decode the MME name from DNS labels to string */
 	osmo_apn_to_str(mme_name, TLVP_VAL(tp, SGSAP_IE_MME_NAME), TLVP_LEN(tp, SGSAP_IE_MME_NAME));
 

-- 
To view, visit https://gerrit.osmocom.org/13627
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d55f9524b9fc15d661e5cb6b5df6d715c52ccf9
Gerrit-Change-Number: 13627
Gerrit-PatchSet: 1
Gerrit-Owner: Omar Ramadan <omar.ramadan93 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190412/04de585f/attachment.htm>


More information about the gerrit-log mailing list