This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13515 ) Change subject: USSD: save MO USSD's originating MSC's vlr_number ...................................................................... Patch Set 7: (2 comments) https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c File src/hlr_ussd.c: https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c@248 PS7, Line 248: ss->vlr_number_len = strlen(subscr.vlr_number) + 1; (I still don't like the +1 on the strlen, I think we may need to discuss the blob plan separately some time) https://gerrit.osmocom.org/#/c/13515/7/src/hlr_ussd.c@562 PS7, Line 562: if (gsup->source_name) { SS/USSD GSUP does not include the source_name. You wrote the routing code, remember? ;) Instead you need to get it from the osmo_gsup_conn if at all. I think you can completely skip this patch chunk. -- To view, visit https://gerrit.osmocom.org/13515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5a65f471672949192061c5fe396603611123bc1 Gerrit-Change-Number: 13515 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 08 Apr 2019 13:35:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/42c9949b/attachment.htm>