Change in libosmocore[master]: Add _c versions of functions that otherwise return static buffers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Mon Apr 8 09:22:01 UTC 2019


Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13311 )

Change subject: Add _c versions of functions that otherwise return static buffers
......................................................................


Patch Set 9: Code-Review+1

I am not against this channge, I see the point of standariging options for APIs, but I'm not really sure about the benefit of introducing _c functions for APIs which already have a _buf one (meaning one can already use them in multithreaded env).

I don't like adding similar APIs for the sake of convenience, because on the other hand it grows libosmocore size, maintainership and complexity to find APIs as a user.

IMHO we should deprecate static buffers and keep only _buf ones, and drop _c or talloc functions as much as possible for simple return types like strings. Of course we want to have/keep _c for APIs returning complex stuff like msgb.


-- 
To view, visit https://gerrit.osmocom.org/13311
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8481c19b68ff67cfa22abb93c405ebcfcb0ab19b
Gerrit-Change-Number: 13311
Gerrit-PatchSet: 9
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 08 Apr 2019 09:22:01 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190408/4e7c7f40/attachment.htm>


More information about the gerrit-log mailing list