This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13479 ) Change subject: fix USSD routing to multiple MSC ...................................................................... Patch Set 5: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/13479/5/src/hlr_ussd.c File src/hlr_ussd.c: https://gerrit.osmocom.org/#/c/13479/5/src/hlr_ussd.c@238 PS5, Line 238: ss->subscr This will always remain NULL, because AFAICS you never set this pointer... https://gerrit.osmocom.org/#/c/13479/5/src/hlr_ussd.c@251 PS5, Line 251: return -EINVAL; memleak: msg was allocated dynamically, so here you need to free it. https://gerrit.osmocom.org/#/c/13479/5/src/hlr_ussd.c@260 PS5, Line 260: return -EINVAL; same here. https://gerrit.osmocom.org/#/c/13479/5/src/hlr_ussd.c@263 PS5, Line 263: USSD 'SS/USSD' would be more correct, as we would also deal with "structured" Supplementary Services some day. https://gerrit.osmocom.org/#/c/13479/5/src/hlr_ussd.c@286 PS5, Line 286: resp_msg = gsm0480_msgb_alloc_name(__func__); So here we allocate a message buffer on heap... BTW (off-topic): why do we use gsm0480_msgb_alloc_name()? We have nothing to do with GSM 04.80 at the HLR - it's only used to encapsulate the SS payload between MS and MSC. This is not that critical, but may be misleading. Also, gsm0480_msgb_alloc_name() allocates a smaller buffer: return msgb_alloc_headroom(1024, 128, name); than osmo_gsup_client_msgb_alloc() does: return msgb_alloc_headroom(4000, 64, __func__); -- To view, visit https://gerrit.osmocom.org/13479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18067bfadd33a6bc59a9ee336b6937313826fce3 Gerrit-Change-Number: 13479 Gerrit-PatchSet: 5 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Fri, 05 Apr 2019 19:34:50 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190405/d4a0a0d3/attachment.htm>