Change in osmo-bsc[master]: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Apr 4 14:47:06 UTC 2019


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13522 )

Change subject: abis_nm.c: use msgb_lv_put() to put abis_nm_ipa_magic
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/13522/1/src/osmo-bsc/abis_nm.c
File src/osmo-bsc/abis_nm.c:

https://gerrit.osmocom.org/#/c/13522/1/src/osmo-bsc/abis_nm.c@2818
PS1, Line 2818: 	msgb_lv_put(msg, sizeof(abis_nm_ipa_magic),
> Are you sure this doesn't fit in one line?
Of course it does fit in 120 chars long line, but at that moment I have been using vim in my regular 80 chars terminal. Personally, I still prefer the 80 chars limitation. If you insist, I can modify this patch.



-- 
To view, visit https://gerrit.osmocom.org/13522
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ce97fc28a608894c8dfa3bbc55032e66bc44e5b
Gerrit-Change-Number: 13522
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 04 Apr 2019 14:47:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190404/f3c5ec13/attachment.htm>


More information about the gerrit-log mailing list