Change in libosmo-sccp[master]: sccp_scoc: Add more comments describing conn_id and local_ref members

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 1 14:09:13 UTC 2019


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13477 )

Change subject: sccp_scoc: Add more comments describing conn_id and local_ref members
......................................................................

sccp_scoc: Add more comments describing conn_id and local_ref members

Change-Id: I85cabc42621103de1a83282baf210fbc117b63db
---
M src/sccp_scoc.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c
index cb1d567..e58251f 100644
--- a/src/sccp_scoc.c
+++ b/src/sccp_scoc.c
@@ -83,7 +83,15 @@
 	/* local/remote addresses and identiies */
 	struct osmo_sccp_addr calling_addr;
 	struct osmo_sccp_addr called_addr;
+	/* SCCP connection identifier. Only relevant across the SCCP User SAP,
+	 * i.e. between the local application using the SCCP stack provided by
+	 * libosmo-sccp.  Never transmitted over the wire! */
 	uint32_t conn_id;
+	/* SCCP Remote Connection Reference.  Allocated by the remote
+	 * SCCP stack to uniquely identify a SCCP connection on its end.
+	 * We don't interpret it, but simply cache it here so we can use
+	 * it whever sending data to the peer. Only relevant over the
+	 * wire, not to be used across the SCCP user SAP */
 	uint32_t remote_ref;
 
 	uint32_t importance;

-- 
To view, visit https://gerrit.osmocom.org/13477
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I85cabc42621103de1a83282baf210fbc117b63db
Gerrit-Change-Number: 13477
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190401/2ce295cd/attachment.htm>


More information about the gerrit-log mailing list