This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/13470 ) Change subject: libmsc/db.c: fix incorrect SMS UD length truncation ...................................................................... Patch Set 1: Code-Review+1 (1 comment) makes sense from the type safety angle. Not sure whether truncating SMS data is what we should do, but this patch is definitely an improvement. https://gerrit.osmocom.org/#/c/13470/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/13470/1//COMMIT_MSG@28 PS1, Line 28: 'sms->user_data_len' is of type 'uint8_t', these warnings make sense. until now the commit log reads like a verbose version of "fix compiler warning" ... the interesting part starts below, "fix integer overflow". It's fine, leave it, maybe next time start with the interesting bit :) -- To view, visit https://gerrit.osmocom.org/13470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbd588545e1a4817504c806a3d02cf59d5938ee2 Gerrit-Change-Number: 13470 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 01 Apr 2019 11:50:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190401/3b53b037/attachment.htm>