Change in osmo-ttcn3-hacks[master]: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 28 23:11:16 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11149 )

Change subject: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn@1371
PS1, Line 1371: 	f_L1CTL_PARAM(L1CTL, ta, tx_power);
> Why do we need both variables? […]
In the context of "developer economy", let's please not debate such topics.  Some people like to use a local variable to shorten the line length, others don't.  Especially in this example, both variants are equally readable.



-- 
To view, visit https://gerrit.osmocom.org/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1fd9cee3472c7aa6580f846d277f485d3401641
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 23:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/86139f2d/attachment.htm>


More information about the gerrit-log mailing list