Change in osmo-ttcn3-hacks[master]: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11149 )

Change subject: bts: Use f_L1CTL_PARAM to set expected ms power level for dummy MeasRep
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG@11
PS1, Line 11: dummy
As I already mentioned in 11138, the firmware actually
implements MR caching. Dummy ones are being sent before
the first MR received from L23, then cached MR is used.

As soon as we mere 11138, trxcon will also follow this approach.


https://gerrit.osmocom.org/#/c/11149/1//COMMIT_MSG@13
PS1, Line 13: Those
Only dummy MRs are filled with the actual parameters,
cached ones remain the same until the next one appears.


https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/11149/1/bts/BTS_Tests.ttcn@1371
PS1, Line 1371: 	f_L1CTL_PARAM(L1CTL, ta, tx_power);
Why do we need both variables?
Why not to pass the values directly?

  f_L1CTL_PARAM(L1CTL,
    g_pars.l1_pars.ms_actual_ta,
    g_pars.l1_pars.ms_power_level);

should work just fine...



-- 
To view, visit https://gerrit.osmocom.org/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1fd9cee3472c7aa6580f846d277f485d3401641
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 15:48:32 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/00b03fed/attachment.htm>