This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11083 ) Change subject: bts: Add module parameters with tolerance to support real HW ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/11083/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11083/4//COMMIT_MSG@7 PS4, Line 7: bts: Add module parameters with tolerance to support real HW > If the commit message states that we "add module parameters", […] Agree https://gerrit.osmocom.org/#/c/11083/4/library/L1CTL_Types.ttcn File library/L1CTL_Types.ttcn: https://gerrit.osmocom.org/#/c/11083/4/library/L1CTL_Types.ttcn@281 PS4, Line 281: L1ctlDataReq > The L1CTL_DATA_REQ is not only used to carry SACCH messages. […] That's why l1header is defined as optional. ts_L1CTL_DATA_REQ still uses "octetstring other", but could be changed to use L1ctlDataReq with l1header := omit. It already contains the info_ul part, see ts_L1CTL_DATA_REQ and ts_L1CTL_DATA_REQ_SACCH. I'll look into adding it to L3_Templates. I added it here since it looked like the less aggressive change, and I couldn't find a real good place for it (since it's actually a L1 header, not l2 apparently. -- To view, visit https://gerrit.osmocom.org/11083 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf1d2216d29c1ebf68c672e6ca06c54a7457304b Gerrit-Change-Number: 11083 Gerrit-PatchSet: 4 Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Fri, 28 Sep 2018 13:46:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/08676a0f/attachment.htm>