Change in osmocom-bb[master]: trxcon/scheduler: fix Measurement Reporting on SACCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Fri Sep 28 10:58:21 UTC 2018


Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11138 )

Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c
File src/host/trxcon/sched_prim.c:

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@143
PS2, Line 143: "Dummy" Measurement Report
> should the L1 SACCH header even of the dummy not contain the actual MS power level that is used / th […]
Done


https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@192
PS2, Line 192: 	LOGP(DSCHD, LOGL_NOTICE, "Transmitting a %s Measurement Report "
> We are not transmitting here. […]
Done


https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_trx.h
File src/host/trxcon/sched_trx.h:

https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_trx.h@196
PS2, Line 196: 		uint8_t mr_tx_last; /*!< 0x01 - yes, 0x00 - no */
> why not using a bool here?
Done



-- 
To view, visit https://gerrit.osmocom.org/11138
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d
Gerrit-Change-Number: 11138
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 28 Sep 2018 10:58:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/5bf7d486/attachment.htm>


More information about the gerrit-log mailing list