Change in osmo-dev[master]: run tcpdump *after* finding programs (not before)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Fri Sep 28 10:27:47 UTC 2018


osmith has posted comments on this change. ( https://gerrit.osmocom.org/11142 )

Change subject: run tcpdump *after* finding programs (not before)
......................................................................


Patch Set 1: Code-Review-1

tcpdump runs in the background. With this change it runs after setting the program variables.

Now that you've asked me to look at it again, I realize that I made a mistake here, I thought the script would also check for the xterm program while filling the program variables (see the term() function above). But that is not the case, the term() function gets executed afterwards.

So this commit will only make sense when the part that checks if xterm or urxvt is installed gets executed before starting the tcpdump instances.

(I've added this after the last patch originally, which adds support for osmo-sip-connector, and there I check if the sip server is installed while filling out the program variables.)

Thanks for looking through the patches!


-- 
To view, visit https://gerrit.osmocom.org/11142
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If487c357cbae504410545d2ed00d7e22f5e60f4f
Gerrit-Change-Number: 11142
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 28 Sep 2018 10:27:47 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/88368569/attachment.htm>


More information about the gerrit-log mailing list