This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Pau Espin Pedrol gerrit-no-reply at lists.osmocom.orgPau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11138 ) Change subject: trxcon/scheduler: fix Measurement Reporting on SACCH ...................................................................... Patch Set 2: Code-Review-1 (5 comments) I expect a similar patch for l23_api/l1 firmware as there's some similar code there, right? https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c File src/host/trxcon/sched_prim.c: https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@180 PS2, Line 180: prim->payload[0] = trx->tx_power; I think this should be done (without if 0) in line 172, in the dummy meas rep case. https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@192 PS2, Line 192: LOGP(DSCHD, LOGL_NOTICE, "Transmitting a %s Measurement Report " We are not transmitting here. Maybe Using? Retrieving? https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@234 PS2, Line 234: mr_now = !lchan->sacch.mr_tx_last; With this toggle and above coment from "sub-clause 3.4.1" I understand there's 2 SACCH slots per L2 frame. Am I right? https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_prim.c@259 PS2, Line 259: if (mr_now && prim_mr) This if-else clause can be merged into previous 2 ifs, and it's way clear imho. if (!prim_mr && PRIM_IS_MR(prim)) { prim_mr = prim; if (mr_now) break; } I think you can even drop the prim_mr and !prim_nmr and directly ubreak and use prim after the loop. https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_trx.h File src/host/trxcon/sched_trx.h: https://gerrit.osmocom.org/#/c/11138/2/src/host/trxcon/sched_trx.h@196 PS2, Line 196: uint8_t mr_tx_last; /*!< 0x01 - yes, 0x00 - no */ why not using a bool here? -- To view, visit https://gerrit.osmocom.org/11138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1b8dc74ced746d6270676fdde75fcda32f91a3d Gerrit-Change-Number: 11138 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 28 Sep 2018 10:09:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/be662efe/attachment.htm>