Change in libosmocore[master]: osmo-config-merge: Add manual page

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 28 09:58:19 UTC 2018


Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11133 )

Change subject: osmo-config-merge: Add manual page
......................................................................


Patch Set 3: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/11133/3/configure.ac
File configure.ac:

https://gerrit.osmocom.org/#/c/11133/3/configure.ac@87
PS3, Line 87: 	    [AC_MSG_ERROR([a2x not found, please install asciidoc])])
makes sense to state "or use --disable-man-doc" here


https://gerrit.osmocom.org/#/c/11133/3/man/Makefile.am
File man/Makefile.am:

https://gerrit.osmocom.org/#/c/11133/3/man/Makefile.am@9
PS3, Line 9: osmo-config-merge.8 : ${ASCIIDOCS}
So the left hand side (target) is for one man page explicitly (osmo-config-merge.8) while on the right hand side (dependencies) we list all ASCIIDOC manpages.  Currently this works.

But what if there are going to be more man pages?  I think it makes sense to have a general rule like %.8: %.txt or actually even better %.8: %.adoc (to make sure editors know its an asciidoc file).


https://gerrit.osmocom.org/#/c/11133/3/man/osmo-config-merge.txt
File man/osmo-config-merge.txt:

https://gerrit.osmocom.org/#/c/11133/3/man/osmo-config-merge.txt@62
PS3, Line 62: osmo-config-merge was written by Harald Welte
Debian always lists who wrote the man page here, too.  So give yourself some credit :)



-- 
To view, visit https://gerrit.osmocom.org/11133
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaa5afe28779a805764caf76a89efb0a3169942e
Gerrit-Change-Number: 11133
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Fri, 28 Sep 2018 09:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180928/020e8a6f/attachment.htm>


More information about the gerrit-log mailing list