This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11132 ) Change subject: osmo-config-merge: Fix some small issues ...................................................................... Patch Set 3: (2 comments) Don't get my hypercriticism wrong please ;) https://gerrit.osmocom.org/#/c/11132/3/utils/osmo-config-merge.c File utils/osmo-config-merge.c: https://gerrit.osmocom.org/#/c/11132/3/utils/osmo-config-merge.c@130 PS3, Line 130: read I think "Could not open ..." would be a bit more informative. Additionally, printing: "Could not open file '%s': (rc=%d) %s\n" % (fname, rc, strerror(errno)) would make this message even more informative. https://gerrit.osmocom.org/#/c/11132/3/utils/osmo-config-merge.c@236 PS3, Line 236: Not sure we need this white space. Let's just remove this chunk without replacing it with empty lines... -- To view, visit https://gerrit.osmocom.org/11132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I966e63a3f7d0ff71ee0b88922aa3807d073aa232 Gerrit-Change-Number: 11132 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Thu, 27 Sep 2018 20:19:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/a42f5424/attachment.htm>