Change in libosmo-sccp[master]: sccp_vty: fix doc strings for show ... ssn, connections

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Sep 27 16:03:11 UTC 2018


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11121 )

Change subject: sccp_vty: fix doc strings for show ... ssn,connections
......................................................................

sccp_vty: fix doc strings for show ... ssn,connections

For 'show cs7 instance 0 ssn', fix doc string for 'ssn', and add missing one
for the SSN arg. This fixes depending builds that see VTY test failures due to
the missing doc string.

For 'show cs7 instance 0 connectsion', fix doc string for 'connections'.

Change-Id: I214ea51fc6bfa2a9a4dd7c34b43add0c77ffe22e
---
M src/sccp_vty.c
M tests/vty/ss7_asp_test.vty
2 files changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/sccp_vty.c b/src/sccp_vty.c
index 2727ccc..b11fec5 100644
--- a/src/sccp_vty.c
+++ b/src/sccp_vty.c
@@ -83,7 +83,8 @@
 DEFUN(show_sccp_user_ssn, show_sccp_user_ssn_cmd,
 	"show cs7 instance <0-15> sccp ssn <0-65535>",
 	SHOW_STR CS7_STR INST_STR INST_STR SCCP_STR
-	"Show List of SCCP Users registered\n")
+	"Find an SCCP User registered for the given SSN\n"
+	"Subsystem Number (SSN)\n")
 {
 	int id = atoi(argv[0]);
 	int ssn = atoi(argv[1]);
@@ -117,7 +118,7 @@
 DEFUN(show_sccp_connections, show_sccp_connections_cmd,
 	"show cs7 instance <0-15> sccp connections",
 	SHOW_STR CS7_STR INST_STR INST_STR SCCP_STR
-	"Show List of SCCP Users registered\n")
+	"Show List of active SCCP connections\n")
 {
 	int id = atoi(argv[0]);
 	struct osmo_ss7_instance *inst;
diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty
index fee97b3..05c7527 100644
--- a/tests/vty/ss7_asp_test.vty
+++ b/tests/vty/ss7_asp_test.vty
@@ -55,11 +55,11 @@
 ss7_asp_vty_test# show cs7 instance 0 sccp ?
   addressbook  List all SCCP addressbook entries
   users        Show List of SCCP Users registered
-  ssn          Show List of SCCP Users registered
-  connections  Show List of SCCP Users registered
+  ssn          Find an SCCP User registered for the given SSN
+  connections  Show List of active SCCP connections
 
 ss7_asp_vty_test# show cs7 instance 0 sccp ssn ?
-  <0-65535>
+  <0-65535>  Subsystem Number (SSN)
 
 ss7_asp_vty_test# configure terminal
 ss7_asp_vty_test(config)# cs7 instance 0

-- 
To view, visit https://gerrit.osmocom.org/11121
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I214ea51fc6bfa2a9a4dd7c34b43add0c77ffe22e
Gerrit-Change-Number: 11121
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/2eb56b5a/attachment.htm>


More information about the gerrit-log mailing list