This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgNeels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/11116 ) Change subject: vty: tweak two printed strings ...................................................................... vty: tweak two printed strings Fix typo "to long". Say 'cs7 instance' instead of 'ss7 instance': we are interacting with a user on the telnet VTY, and that user is configuring a 'cs7 instance'. Especially a lowercase 'ss7' is potentially confusing ("is there an 'ss7' node?"). Changes show in ss7_asp_test.vty. Change-Id: Iebb976531576268d58338895a4baadbca6137b80 --- M src/osmo_ss7_vty.c M tests/vty/ss7_asp_test.vty 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c index 295fc20..1e2f437 100644 --- a/src/osmo_ss7_vty.c +++ b/src/osmo_ss7_vty.c @@ -1289,7 +1289,7 @@ const char *name = argv[0]; if (strlen(name) >= sizeof(entry->name)) { - vty_out(vty, "Error: SCCP address name to long: '%s'%s", + vty_out(vty, "Error: SCCP address name too long: '%s'%s", name, VTY_NEWLINE); return CMD_ERR_INCOMPLETE; } @@ -1299,7 +1299,7 @@ entry = addr_entry_by_name_global(name); if (entry != NULL) { vty_out(vty, - "Error: SCCP address name already used in ss7 instance %u: '%s'%s", + "Error: SCCP address name already used in cs7 instance %u: '%s'%s", entry->inst->cfg.id, entry->name, VTY_NEWLINE); return CMD_ERR_INCOMPLETE; } diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index 9a86b23..f96e0c0 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -180,13 +180,13 @@ ss7_asp_vty_test(config-cs7-sccpaddr)# exit ss7_asp_vty_test(config-cs7)# sccp-address foobarfoobarfoobarfoobarfoobarfoobar -Error: SCCP address name to long: 'foobarfoobarfoobarfoobarfoobarfoobar' +Error: SCCP address name too long: 'foobarfoobarfoobarfoobarfoobarfoobar' % Command incomplete. ss7_asp_vty_test(config-cs7)# exit ss7_asp_vty_test(config)# cs7 instance 1 ss7_asp_vty_test(config-cs7)# sccp-address foo -Error: SCCP address name already used in ss7 instance 0: 'foo' +Error: SCCP address name already used in cs7 instance 0: 'foo' % Command incomplete. ss7_asp_vty_test(config-cs7)# sccp-address bar ss7_asp_vty_test(config-cs7-sccpaddr)# point-code 1.2.3 -- To view, visit https://gerrit.osmocom.org/11116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iebb976531576268d58338895a4baadbca6137b80 Gerrit-Change-Number: 11116 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/c2a2aa64/attachment.htm>