Change in libosmo-sccp[master]: build: move include/{mtp, sccp} to include/osmocom/

historical

Hello Harald Welte, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/11120

to look at the new patch set (#5).

Change subject: build: move include/{mtp,sccp} to include/osmocom/
......................................................................

build: move include/{mtp,sccp} to include/osmocom/

Anywhere else in the Osmocom code base, we arrange headers in
include/osmocom/foo/ and pass -I ${root_srcdir}/include/.
This way including an osmocom header always has the format
  #include <osmocom/foo/bar.h>
whether we are including from the local source tree or from $prefix.

For some reason not clear to me, the mtp and sccp folders, even though they are
being installed to $prefix/include/osmocom/, were kept *next* to the osmocom/
dir, instead of inside it. Fix that weird situation.

The motivation is that I wanted to use a definition from sccp_types.h in a
public-API header. That is impossible if it requires
  #include <sccp/sccp_types.h>
in a local build, but
  #include <osmocom/sccp/sccp_types.h>
for any other source tree using libosmo-sccp. After this patch, both are
identical and including works without quirks. (The other patch that needed this
has changed in the meantime on and no longer needs this, but this still makes
sense for future hacking.)

The installed result does not change, since both mtp/*.h and sccp/*.h have
always been installed to $prefix/include/osmocom/{mtp,sccp}/. This merely
changes their position in the source tree.

The most curious situation before this is that any patch #including
<osmocom/sccp/sccp_types.h> might not get a notice that the header didn't
exist, but might instead include an older system-installed file.

Change-Id: I1209a4ecf9f692a8030b5c93cd281fc9dd58d105
---
M configure.ac
M include/Makefile.am
M include/osmocom/Makefile.am
R include/osmocom/mtp/Makefile.am
R include/osmocom/mtp/mtp_level3.h
R include/osmocom/mtp/mtp_pcap.h
R include/osmocom/sccp/Makefile.am
R include/osmocom/sccp/sccp.h
R include/osmocom/sccp/sccp_types.h
M src/mtp_pcap.c
M src/sccp.c
M src/sccp2sua.c
M src/sccp_sclc.c
M src/sccp_scoc.c
M src/sccp_scrc.c
M tests/mtp/mtp_parse_test.c
M tests/sccp/sccp_test.c
17 files changed, 12 insertions(+), 12 deletions(-)

  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/20/11120/5
-- 
To view, visit https://gerrit.osmocom.org/11120
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1209a4ecf9f692a8030b5c93cd281fc9dd58d105
Gerrit-Change-Number: 11120
Gerrit-PatchSet: 5
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/8ae7cd27/attachment.htm>