Change in libosmo-sccp[master]: vty: fix 'show asp' from within 'asp' node

[Neels Hofmeyr]

Neels Hofmeyr has uploaded this change for review. ( https://gerrit.osmocom.org/11113


Change subject: vty: fix 'show asp' from within 'asp' node
......................................................................

vty: fix 'show asp' from within 'asp' node

When entering an 'cs7' / 'asp' node, and invoking 'do show cs7 i 0 asp', the
ASP's FSM instance is not yet allocated. Hence attempting to print its status
will result in a segfault.

Spotted this while writing VTY tests that will follow shortly in another patch
(I6a28684fa24d6e7de568623444297028eba2ab8c).

Change-Id: I3ebf498492c6ba69a5dd1c9f36acdabfd6fbdfe1
---
M src/osmo_ss7_vty.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/13/11113/1

diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index c66a781..295fc20 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -666,7 +666,8 @@
 
 	llist_for_each_entry(asp, &inst->asp_list, list) {
 		vty_out(vty, "%-12s  %-12s  %-13s  %-4s  %-8u %-15s %-10s%s",
-			asp->cfg.name, "?", osmo_fsm_inst_state_name(asp->fi),
+			asp->cfg.name, "?",
+			asp->fi? osmo_fsm_inst_state_name(asp->fi) : "uninitialized",
 			get_value_string(osmo_ss7_asp_protocol_vals, asp->cfg.proto),
 			asp->cfg.remote.port, asp->cfg.remote.host, "", VTY_NEWLINE);
 	}

-- 
To view, visit https://gerrit.osmocom.org/11113
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ebf498492c6ba69a5dd1c9f36acdabfd6fbdfe1
Gerrit-Change-Number: 11113
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180927/6f6963f0/attachment.htm>