Change in docker-playground[master]: debian-repo-install-test: new binary package test

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Wed Sep 19 14:03:05 UTC 2018


osmith has posted comments on this change. ( https://gerrit.osmocom.org/10862 )

Change subject: debian-repo-install-test: new binary package test
......................................................................


Patch Set 6:

(2 comments)

> No merge yet since I think some stuff is still being prepared. Better mark is as WIP meanwhile.

It's pretty much finished already, I'll just switch `docker run` parameters, so we don't need `--entrypoint`.

https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/jenkins.sh
File debian-repo-install-test/jenkins.sh:

https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/jenkins.sh@14
PS6, Line 14: 		--entrypoint "/testdata/repo-install-test.sh" \
> interesting, --entrypoint; so far in the other jenkins. […]
I haven't really used docker much (besides in gitlab-ci configs, where you don't specify a `docker run` command line), so I wasn't aware that you can put the command as last argument. I figured `--entrypoint` would be the way to do it. 

But now that you say it, placing it at the end is shorter and it even allows specifying arguments to the commands. This is the better way then, I'll push another patch that changes this.

(I guess the difference is, that with the entrypoint you could override the default shell.)


https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/testdata/repo-install-test.sh
File debian-repo-install-test/testdata/repo-install-test.sh:

https://gerrit.osmocom.org/#/c/10862/6/debian-repo-install-test/testdata/repo-install-test.sh@49
PS6, Line 49: 	osmo-bsc --version
> it's not really the task at hand, but in the past we also had the problem that some packages would g […]
created https://osmocom.org/issues/3555 for that



-- 
To view, visit https://gerrit.osmocom.org/10862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f0a8b4f0ccd706cd1af98fe25accd6fd410e007
Gerrit-Change-Number: 10862
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Sep 2018 14:03:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180919/256c4967/attachment.htm>


More information about the gerrit-log mailing list