Change in osmo-bts[master]: CBCH: Fix CBCH via L1SAP for osmo-bts-{sysmo, octphy, litecell15}

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Sep 17 19:27:13 UTC 2018


Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11003


Change subject: CBCH: Fix CBCH via L1SAP for osmo-bts-{sysmo,octphy,litecell15}
......................................................................

CBCH: Fix CBCH via L1SAP for osmo-bts-{sysmo,octphy,litecell15}

This fixes a bug introduced in "CBCH: Move processing via L1SAP"

commit 02d99db08b13589e1417c3448a07747f8805ba88
Author: Harald Welte <laforge at gnumonks.org>
Date:   Fri Aug 24 23:37:45 2018 +0200

where the full channel number 0xc8 was used instead of the
(right-shifted) C-bits only.

Change-Id: I0fd8d7762e9cc3319a534f261e8857a1aa2220e0
---
M src/osmo-bts-litecell15/l1_if.c
M src/osmo-bts-octphy/l1_if.c
M src/osmo-bts-sysmo/l1_if.c
3 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/03/11003/1

diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c
index 82299ff..cfe1a05 100644
--- a/src/osmo-bts-litecell15/l1_if.c
+++ b/src/osmo-bts-litecell15/l1_if.c
@@ -700,7 +700,7 @@
 		cbits = 0x10;
 		break;
 	case GsmL1_Sapi_Cbch:
-		cbits = 0xc8; /* Osmocom extension for CBCH via L1SAP */
+		cbits = 0xc8 >> 3; /* Osmocom extension for CBCH via L1SAP */
 		break;
 	case GsmL1_Sapi_Sacch:
 		switch(pchan) {
diff --git a/src/osmo-bts-octphy/l1_if.c b/src/osmo-bts-octphy/l1_if.c
index 35d0aa3..a02eb0d 100644
--- a/src/osmo-bts-octphy/l1_if.c
+++ b/src/osmo-bts-octphy/l1_if.c
@@ -357,7 +357,7 @@
 		cbits = 0x10;
 		break;
 	case cOCTVC1_GSM_SAPI_ENUM_CBCH:
-		cbits = 0xc8; /* Osmocom extension for CBCH via L1SAP */
+		cbits = 0xc8 >> 3; /* Osmocom extension for CBCH via L1SAP */
 		break;
 	case cOCTVC1_GSM_SAPI_ENUM_SACCH:
 		switch (pchan) {
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c
index c0b42b4..acc43aa 100644
--- a/src/osmo-bts-sysmo/l1_if.c
+++ b/src/osmo-bts-sysmo/l1_if.c
@@ -697,7 +697,7 @@
 		cbits = 0x10;
 		break;
 	case GsmL1_Sapi_Cbch:
-		cbits = 0xc8; /* Osmocom extension for CBCH via L1SAP */
+		cbits = 0xc8 >> 3; /* Osmocom extension for CBCH via L1SAP */
 		break;
 	case GsmL1_Sapi_Sacch:
 		switch(pchan) {

-- 
To view, visit https://gerrit.osmocom.org/11003
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fd8d7762e9cc3319a534f261e8857a1aa2220e0
Gerrit-Change-Number: 11003
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180917/ef2d1b67/attachment.htm>


More information about the gerrit-log mailing list