This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10942 ) Change subject: trxcon/scheduler: introduce TDMA frame math helpers ...................................................................... Patch Set 1: (1 comment) I am wondering, may we share this code somewhere in libosmocore? I just checked both OsmocomBB firmware and osmo-bts-trx - in both cases the frame number of decoded L2 frame on TCH/H is calculated in a wrong way. The firmware is just using frame number of the last burst, while OsmoBTS is using frame number of 3/4 burst for speech, and 5/6 burst for FACCH/H (bid == 0). TCH/F channel is also affected: the firmware is using frame number of the last 8/8 burst, osmo-bts-trx is using frame number of 4/8 burst, while for xCCH the correct frame number of 1/4 burst is used everywhere... This also raises a question: why should we use frame number of the first burst in general? Why not frame number of the last? https://gerrit.osmocom.org/#/c/10942/1/src/host/trxcon/scheduler.h File src/host/trxcon/scheduler.h: https://gerrit.osmocom.org/#/c/10942/1/src/host/trxcon/scheduler.h@14 PS1, Line 14: #define TDMA_FN_SUM(a, b) \ > you could implement TDMA_FN_INC(fn) as TDMA_FN_SUM(fn, 1) Sure, thanks! -- To view, visit https://gerrit.osmocom.org/10942 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb66ba846cc3d6c2eaa88414569e5f3751128047 Gerrit-Change-Number: 10942 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Comment-Date: Sat, 15 Sep 2018 18:44:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180915/72f855fb/attachment.htm>