Change in libosmocore[master]: gsm0808: fix wrong codec defaults for OFR_AMR_WB

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Sep 15 07:57:21 UTC 2018


Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10960 )

Change subject: gsm0808: fix wrong codec defaults for OFR_AMR_WB
......................................................................

gsm0808: fix wrong codec defaults for OFR_AMR_WB

3GPP TS 48.008 chapter 3.2.2.103 states that the configuration bits of
OFR_AMR_WB are coded as follows:

"S0, S2, S4 indicates the supported Codec Configurations. S1, S3, S5, S6,
S7 are reserved and coded with zeroes."

The current default setting of 0x3F violates this requirement. Lets set
the "forbidden" settings zu zero and keep only the allowed ones.

Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130
---
M include/osmocom/gsm/protocol/gsm_08_08.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h
index 69007b5..9433817 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -499,7 +499,7 @@
 	GSM0808_SC_CFG_DEFAULT_HR_AMR		= 0x073f,
 	GSM0808_SC_CFG_DEFAULT_OHR_AMR		= 0x57ff,
 	GSM0808_SC_CFG_DEFAULT_FR_AMR_WB	= 0x01,
-	GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB	= 0x3f,
+	GSM0808_SC_CFG_DEFAULT_OFR_AMR_WB	= 0x15,
 	GSM0808_SC_CFG_DEFAULT_OHR_AMR_WB	= 0x01,
 };
 

-- 
To view, visit https://gerrit.osmocom.org/10960
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a481def59e9c98cfdcafc2b80c0ac7df0c14130
Gerrit-Change-Number: 10960
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180915/e829619b/attachment.htm>


More information about the gerrit-log mailing list