Change in gr-gsm[master]: burst_file_source: Fix reading longer bursts

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vasil Velichkov gerrit-no-reply at lists.osmocom.org
Wed Sep 12 11:02:03 UTC 2018


Hello Piotr Krysik, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/10881

to look at the new patch set (#2).

Change subject: burst_file_source: Fix reading longer bursts
......................................................................

burst_file_source: Fix reading longer bursts

- Read bursts with pmt::deserialize directly from the std::filebuf
- Remove the unused unserialized variable
- Add tests

Since df978693 when the rx_time tags are present in the incomming stream
the gsm receiver adds fm_time to the burst's PMT and the bursts that
burst file sink writes becomes longer because of the additional field.

The burst file source block was expecting all burst to be 147 bytes long
and reading files with longer bursts was failing with an unhandled exception.

terminate called after throwing an instance of 'pmt::exception'
thread[thread-per-block[5]: <block dummy_burst_filter (2)>]: pmt_cdr: wrong_type : #f
  what():  pmt::deserialize: malformed input stream, tag value = : 115

Change-Id: I989b0d6a6b214088b7880e5cbf7bb6725492dbfc
---
M lib/misc_utils/burst_file_source_impl.cc
M lib/qa_utils/burst_source_impl.cc
M python/CMakeLists.txt
A python/qa_burst_file_source.py
4 files changed, 109 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/81/10881/2
-- 
To view, visit https://gerrit.osmocom.org/10881
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: gr-gsm
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I989b0d6a6b214088b7880e5cbf7bb6725492dbfc
Gerrit-Change-Number: 10881
Gerrit-PatchSet: 2
Gerrit-Owner: Vasil Velichkov <vvvelichkov at gmail.com>
Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com>
Gerrit-Reviewer: Vasil Velichkov <vvvelichkov at gmail.com>
Gerrit-CC: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180912/02e2903a/attachment.htm>


More information about the gerrit-log mailing list