This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Piotr Krysik gerrit-no-reply at lists.osmocom.orgPiotr Krysik has posted comments on this change. ( https://gerrit.osmocom.org/10832 ) Change subject: apps/grgsm_trx: migrate from getopt to argparse ...................................................................... Patch Set 1: Verified+1 Code-Review+2 (2 comments) This is not just rework of the previous change, some of my changes were just thrown away without explanation. See the comments. https://gerrit.osmocom.org/#/c/10832/1/apps/grgsm_trx File apps/grgsm_trx: https://gerrit.osmocom.org/#/c/10832/1/apps/grgsm_trx@55 PS1, Line 55: argv _hz suffix is redundant, of course frequency is in Hz https://gerrit.osmocom.org/#/c/10832/1/apps/grgsm_trx@71 PS1, Line 71: self.radio.freq_offset_hz = self.phy_freq_offset_hz this should be passed as parameter to radio_if, there is no reason to set it to None in any circumstances, it can safely be 0 by default -- To view, visit https://gerrit.osmocom.org/10832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I24a17b4cd44db0ce95a19d7470f4f09f3c85a26d Gerrit-Change-Number: 10832 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com> Gerrit-Reviewer: Piotr Krysik <ptrkrysik at gmail.com> Gerrit-Comment-Date: Tue, 11 Sep 2018 07:41:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180911/a00df491/attachment.htm>