Change in osmocom-bb[master]: trxcon/trx_if.c: drop unused SETPOWER and ADJPOWER

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Thu Sep 6 21:54:28 UTC 2018


Vadim Yanitskiy has submitted this change and it was merged. ( https://gerrit.osmocom.org/10820 )

Change subject: trxcon/trx_if.c: drop unused SETPOWER and ADJPOWER
......................................................................

trxcon/trx_if.c: drop unused SETPOWER and ADJPOWER

I am not sure we need the both control commands, as every burst
on DATA interface has a header that includes TX power.

Change-Id: Id14603e71df6dedb5a843bb3e20a320192dbca3d
---
M src/host/trxcon/trx_if.c
M src/host/trxcon/trx_if.h
2 files changed, 0 insertions(+), 28 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c
index 89331f3..b3735c2 100644
--- a/src/host/trxcon/trx_if.c
+++ b/src/host/trxcon/trx_if.c
@@ -258,31 +258,6 @@
 }
 
 /*
- * SETPOWER sets output power in dB wrt full scale.
- * This command fails if the transmitter and receiver are not running.
- * CMD SETPOWER <dB>
- * RSP SETPOWER <status> <dB>
- */
-
-int trx_if_cmd_setpower(struct trx_instance *trx, int db)
-{
-	return trx_ctrl_cmd(trx, 0, "SETPOWER", "%d", db);
-}
-
-/*
- * ADJPOWER adjusts power by the given dB step.
- * Response returns resulting power level wrt full scale.
- * This command fails if the transmitter and receiver are not running.
- * CMD ADJPOWER <dBStep>
- * RSP ADJPOWER <status> <dBLevel>
-*/
-
-int trx_if_cmd_adjpower(struct trx_instance *trx, int db)
-{
-	return trx_ctrl_cmd(trx, 0, "ADJPOWER", "%d", db);
-}
-
-/*
  * Timeslot Control
  *
  * SETSLOT sets the format of the uplink timeslots in the ARFCN.
diff --git a/src/host/trxcon/trx_if.h b/src/host/trxcon/trx_if.h
index ed6bd3f..be0d41a 100644
--- a/src/host/trxcon/trx_if.h
+++ b/src/host/trxcon/trx_if.h
@@ -61,9 +61,6 @@
 int trx_if_cmd_poweroff(struct trx_instance *trx);
 int trx_if_cmd_echo(struct trx_instance *trx);
 
-int trx_if_cmd_setpower(struct trx_instance *trx, int db);
-int trx_if_cmd_adjpower(struct trx_instance *trx, int db);
-
 int trx_if_cmd_setta(struct trx_instance *trx, int8_t ta);
 
 int trx_if_cmd_rxtune(struct trx_instance *trx, uint16_t band_arfcn);

-- 
To view, visit https://gerrit.osmocom.org/10820
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id14603e71df6dedb5a843bb3e20a320192dbca3d
Gerrit-Change-Number: 10820
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180906/fa02714b/attachment.htm>


More information about the gerrit-log mailing list