Change in osmo-mgw[master]: mgcp_client_test: also verify received conn_id

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Sep 6 13:42:43 UTC 2018


Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/10748 )

Change subject: mgcp_client_test: also verify received conn_id
......................................................................

mgcp_client_test: also verify received conn_id

Include the parsed conn_id in the response cb printout to verify them in
mgcp_client_test.ok.

Change-Id: I6b9b18d4d0867febd75a4d29f8a2fcdf0553ae4c
---
M tests/mgcp_client/mgcp_client_test.c
M tests/mgcp_client/mgcp_client_test.ok
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/tests/mgcp_client/mgcp_client_test.c b/tests/mgcp_client/mgcp_client_test.c
index 4e7e0a7..74ed53e 100644
--- a/tests/mgcp_client/mgcp_client_test.c
+++ b/tests/mgcp_client/mgcp_client_test.c
@@ -102,6 +102,7 @@
 	printf("response cb received:\n");
 	printf("  head.response_code = %d\n", response->head.response_code);
 	printf("  head.trans_id = %u\n", response->head.trans_id);
+	printf("  head.conn_id = %s\n", response->head.conn_id);
 	printf("  head.comment = %s\n", response->head.comment);
 	printf("  audio_port = %u\n", response->audio_port);
 	printf("  audio_ip = %s\n", response->audio_ip);
diff --git a/tests/mgcp_client/mgcp_client_test.ok b/tests/mgcp_client/mgcp_client_test.ok
index 4b1e78c..5e14219 100644
--- a/tests/mgcp_client/mgcp_client_test.ok
+++ b/tests/mgcp_client/mgcp_client_test.ok
@@ -27,6 +27,7 @@
 response cb received:
   head.response_code = 200
   head.trans_id = 1
+  head.conn_id = 1
   head.comment = OK
   audio_port = 16002
   audio_ip = 10.9.1.120

-- 
To view, visit https://gerrit.osmocom.org/10748
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b9b18d4d0867febd75a4d29f8a2fcdf0553ae4c
Gerrit-Change-Number: 10748
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20180906/f9b3d458/attachment.htm>


More information about the gerrit-log mailing list